search

LibertyOS-Development / kernel

The kernel for LibertyOS.
Apache License 2.0
277 stars 12 forks source link

[BUG] Lock file wasn't pushed on the latest release #17

Closed Dylan-DPC closed 1 year ago

Dylan-DPC commented 1 year ago

The Cargo.lock file wasn't pushed on the latest release (0.15.8).

Also ensure you are running cargo check --locked in your CI so such mistakes can be caught at the CI level.

danielteberian commented 1 year ago

It's been a minute. What is the issue?

danielteberian commented 1 year ago

Great to see a Rust contributor here! What a surprise!

I had to take a break from this for a bit, but I am wanting to get back into it. How did you find the repo?

Dylan-DPC commented 1 year ago

Thanks. The issue is that a lock file should be pushed to git every time it is changed (even though in this case it was just a change in the version field).

Yeah sure take your time. I found this issue while i was combing through the dependencies of spin which has an advisory against it, and updating it's dependents to use at least 0.9.8 version. Since you have a lockfile that should be fine, but I would still recommend doing it though at some point.

danielteberian commented 1 year ago

I'm logging in right now. I'll make sure to push the lockfile.

danielteberian commented 1 year ago

Is it fixed?

Dylan-DPC commented 1 year ago

it is but it won't reflect till you make a new release, this should be fine i guess, thanks for the prompt response

danielteberian commented 1 year ago

Okay. I can publish a new release tonight. Are you trying to work on something?

Next thing I want to do is fix the ridiculous structure of the kernel. Referencing modules should not take so long.

Dylan-DPC commented 1 year ago

No I am not working on anything related to this. I am going through all the crates that use spin and updating them as needed.

danielteberian commented 1 year ago

Oh, cool. How often do you do that?

Got any friends who know how to work without the standard library? ;)

Also, I published two releases yesterday. Has the Cargo.lock file made it into the releases?