search

LibertyOS-Development / kernel

The kernel for LibertyOS.
Apache License 2.0
277 stars 12 forks source link

Docker #26

Closed davethiede closed 1 year ago

davethiede commented 1 year ago

This PR:

  1. updates the rust version to 2023-07-11
  2. removes Cargo.lock from .dockerignore
  3. removes obsolete (as of 2023-07-11) feature flags
  4. removes a type ascription that is no longer supported by Rust
  5. updates Cargo.lock
  6. greatly simplifies the Dockerfile removing all redundancies and now depends on rust-toolchain.toml for component, target and channel information.

Features of this PR were inspired by the work of xonmello and earney and replaces https://github.com/LibertyOS-Development/kernel/pull/22

danielteberian commented 1 year ago

I just pushed a new version to the repository. I think I did a few of the things you did, but I am not sure. Can I merge the request?

davethiede commented 1 year ago

you should be able to merge it. the feature flags patch should be redundant now. the rust-toolchain.toml file would create a conflict as I'm using the nightly-2023-07-11 version in my PR.

I don't know why patch e49ec3a showed up here. i was experimenting with bootimage on my forked repo.

danielteberian commented 1 year ago

Why did you close it?

davethiede commented 1 year ago

Why did you close it?

Some of the individual patches are still valid. the full patch set kept getting invalidated by your changes in the same files.