Libki / libki-server

Libki Server
Other
55 stars 28 forks source link

Ubuntu jammy not supported yet in install.sh #283

Closed rootchick closed 1 year ago

rootchick commented 1 year ago

Describe the bug I see that ubuntu jammy (22.04) isn't supported yet by install.sh. Is there a reason for it or have you just not included it yet? I'm happy to help test--I use the contents of install.sh as a basis for writing ansible playbooks for installing Libki.

Deployment architecture:

kylemhall commented 1 year ago

@loidor maintains that script. Assigning.

pescew commented 1 year ago

fwiw I have successfully installed and used libki server on ubuntu 22.04 after modifying the install script. So I don't think it's a matter of incompatibility, just a matter of updating the install script.

kylemhall commented 1 year ago

@rootchick I just took a crack at updating install.sh, let me know if it works! I don't have anything running ubuntu to test it again atm. If you find any package names have changed let me know and I'll get them updated!

rootchick commented 1 year ago

Thank you, will do! I'm not actually using it, I just used the contents for writing ansible playbooks for installing. But if I find any package names that need changing I'll let you know. I'm working on writing a version to install multiple instances (didn't notice the existing playbooks in the repo until I was almost done so I decided to keep going), and I am running into an issue where update_db.pl is getting hung up because after the first instance is created it can't access /tmp/libki_metrics, which looks like it's created by Libki.pm. Should I be doing something differently? This is the bit of ansible code I'm using for running update_db.pl:

  - name: run the libki database installer
    shell: export PERL5LIB=$PERL5LIB:/home/{{ item.name }}/libki-server/lib && perl /home/{{ item.name }}/libki-server/installer/update_db.pl 
    args:
      executable: /bin/bash
    become_user: "{{ item.name }}"
    with_items: "{{ libki_servers }}"

Apologies if it's inappropriate to ask this here.

loidor commented 1 year ago

New job, so no time at all at the moment to work on libki, unfortunately. Hopefully that changes in a couple of months.

Anyway, the script update works perfectly!

kylemhall commented 1 year ago

@rootchick so you are installing multiple instances on a single server? That directory you referenced is for Prometheus metrics. I'm thinking we can add the ability for you to set a separate directory for each instance using an environment variable. Right now it tries to create and use /dev/libki_metrics, with /tmp/libki_metrics as a fallback.

I'm thinking we would have an env like LIBKI_PROM_DIR that you could set to something different when launching each instance. What do you think?

rootchick commented 1 year ago

Hi Kyle,

Yes, I have 9 instances on one server. I got around the error by running update_db.pl as root instead of the libki user for each instance, but I wondered if libki_metrics would be an issue. I think a unique LIBKI_PROM_DIR env for each instance would be a great idea!

Thanks! Cindy

On Fri, Mar 31, 2023, 1:08 PM Kyle M Hall @.***> wrote:

@rootchick https://github.com/rootchick so you are installing multiple instances on a single server? That directory you referenced is for Prometheus metrics. I'm thinking we can add the ability for you to set a separate directory for each instance using an environment variable. Right now it tries to create and use /dev/libki_metrics, with /tmp/libki_metrics as a fallback.

I'm thinking we would have an env like LIBKI_PROM_DIR that you could set to something different when launching each instance. What do you think?

— Reply to this email directly, view it on GitHub https://github.com/Libki/libki-server/issues/283#issuecomment-1492282173, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANSKKGPJSBGO4TWK2B5D6TW64FQVANCNFSM6AAAAAAWEBV6EQ . You are receiving this because you were mentioned.Message ID: @.***>

rootchick commented 1 year ago

@kylemhall are you going to add the LIBKI_PROM_DIR env to r23.05? Would you like me to create a separate issue for it since it's unrelated to jammy support?

kylemhall commented 1 year ago

@rootchick done in master now! You can either set absolute path with the env LIBKI_PROM_DIR, or if the INSTANCE is set and LIBKI_PROM_DIR is not, it will try using "/dev/libki_metrics/INSTANCE".

rootchick commented 1 year ago

Thanks! I'll give it a go!

On Mon, Apr 17, 2023, 12:48 PM Kyle M Hall @.***> wrote:

@rootchick https://github.com/rootchick done in master now! You can either set absolute path with the env LIBKI_PROM_DIR, or if the INSTANCE is set and LIBKI_PROM_DIR is not, it will try using "/dev/libki_metrics/INSTANCE".

— Reply to this email directly, view it on GitHub https://github.com/Libki/libki-server/issues/283#issuecomment-1511731696, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANSKKG63UZSU7OIC64DXSLXBVX45ANCNFSM6AAAAAAWEBV6EQ . You are receiving this because you were mentioned.Message ID: @.***>