search

LibrariesHacked / openlibrary-search

Searching Open Library by keywords to return ISBNs
156 stars 28 forks source link

add command to make sure openlibrary database is used #6

Closed Chloe-Meinshausen closed 1 year ago

Chloe-Meinshausen commented 1 year ago

Hi, thank you so much for creating this project. It has been immensely helpful for me.
I wanted to add /c openlibrary because when I ran the script originally psql kept creating a postgres database and filling tables there instead of using openlibrary.

DaveBathnes commented 1 year ago

Hi Chloe

Thanks so much for the PR and the feedback.

I've merged it as it's definitely worth having in the script. But just a slight warning, I'm very shortly about to apply a complete rewrite to this repository, and it will be overwritten. But, the new scripts do have the equivalent code - see this branch https://github.com/LibrariesHacked/openlibrary-search/blob/1-error-loading-editions/openlibrary-db.sql

The attention this repo has had has been a surprise to me - it was originally just some notes that I didn't publicise but OpenLibrary generously linked to it and so it's had some attention! I'm really interested in hearing about (and supporting) what people are doing in this area. I'd like to make this project a comprehensive database with full text searching and other features. So any requests or thoughts please do get in touch by raising issues!

Thanks

Chloe-Meinshausen commented 1 year ago

Dear Dave, Thank YOU so much for the feedback. That was my first ever, shy PR to an OS project and you accepted it! and therefore made my day. :)

I am fiddling around making a project for myself that involves needing info about books. I started last year but the API was so slow and bad that I decided to come back to it and try loading the db. -then I found your blessed API linked and the rest is history.

Your rewrite is fantastic! I love all the changes you made!
I was working on some changes myself and I integrated them into your version. I am going to make a PR I would love for you to check out. please don't feel obligated to use. I don't want to horn in and be a bother but I'd love to hear your thoughts about it. I will add more details in the actual PR. Thanks again! Chloe