search

LibraryCarpentry / lc-data-intro

Library Carpentry: Introduction to Working with Data (Regular Expressions)
https://librarycarpentry.org/lc-data-intro/
Other
29 stars 84 forks source link

Use of forward slashes #164

Closed PhilReedData closed 4 years ago

PhilReedData commented 4 years ago

In episode 1, in the "Case insensitivity" exercise, the solution includes a forward slash delimiter at the start of the regex, as well as the end. Previously it explains the use at the end, now we are also using it at the start.

Should we explain the use of forward slashes, as they appear in the suggested tools wrapping all regex strings? (I think this is how Javascript uses it.) I don't want to confuse people with too many implementations, perhaps we should just explain it a bit better in the exercise above.

sharilaster commented 4 years ago

@PhilReedData I think it would depend on if that's too much detail up front or not. Thoughts from others? @ppival @ccronje @libcce

ccronje commented 4 years ago

@PhilReedData @sharilaster that's a good idea providing more explanation in the example. Could you please suggest an improvement, and we can review? There is brief mention of the forward slash under 'Using special characters in regular expression matches' but could easily be missed. Addressing in the example is probably the best place to expand on it.

PhilReedData commented 4 years ago

I shall suggest an improvement (fork and PR), thanks everyone.

ccronje commented 4 years ago

Thanks @PhilReedData