search

LibraryCarpentry / lc-data-intro

Library Carpentry: Introduction to Working with Data (Regular Expressions)
https://librarycarpentry.org/lc-data-intro/
Other
29 stars 84 forks source link

Clarify issues links in CONTRIBUTING.md #209

Closed JCSzamosi closed 1 year ago

JCSzamosi commented 1 year ago

This pull request is being submitted to all repos that have been converted to Workbench, so that they reflect a recent update in the Workbench template. The change is probably appropriate for your repository, but you may disagree. I encourage you to look at a description of the problem it fixes found in this comment of this issue.

You will still need to replace example.com/FIXME in the [repo] and [repo-issues] link targets with this repository.

It additionally fixes the broken [how-contribute] link.

github-actions[bot] commented 1 year ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/LibraryCarpentry/lc-data-intro/compare/md-outputs..md-outputs-PR-209

The following changes were observed in the rendered markdown documents:

What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2023-06-13 22:42:04 +0000

JCSzamosi commented 1 year ago

Looks great! I have committed your suggestions to the PR

sharilaster commented 1 year ago

@kevintfrench thanks for looking! In this case, this is standard content and formatting, with the pull request from the folks at the Carpentries who have just updated the lessons across the board. The part that was a little tricky on our side was making sure we got the correct URLs updated that are specific to the lesson, and @JCSzamosi double-checked that too. So it sounds like we're all good on the content and I will go ahead and merge.

kevintfrench commented 1 year ago

Sounds good @sharilaster I appreciate the explanation.