LibraryCarpentry / lc-data-intro

Library Carpentry: Introduction to Working with Data (Regular Expressions)
https://librarycarpentry.org/lc-data-intro/
Other
29 stars 84 forks source link

Update 01-regular-expressions.md #211

Closed kevintfrench closed 1 year ago

kevintfrench commented 1 year ago

Please delete this line and the text below before submitting your contribution.


Thanks for contributing! If this contribution is for instructor training, please send an email to checkout@carpentries.org with a link to this contribution so we can record your progress. You’ve completed your contribution step for instructor checkout just by submitting this contribution.

Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.


github-actions[bot] commented 1 year ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/LibraryCarpentry/lc-data-intro/compare/md-outputs..md-outputs-PR-211

The following changes were observed in the rendered markdown documents:

 01-regular-expressions.md | 2 +-
 md5sum.txt                | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2023-07-03 10:31:21 +0000

kevintfrench commented 1 year ago

I found the link is not https but http so it may be worth finding another example though this is an excellent one.

sharilaster commented 1 year ago

Hi @kevintfrench, it looks like this is responding to issue #210, is that correct? I tagged that issue as a Good First Issue but based on your note about the http link, maybe it is a bit more complicated than I first thought! It looks like Bohyun may no longer be updating/maintaining her blog, which is why there isn't a version currently available in https.

I think a good strategy may be to link to the original published version, which is here: https://acrl.ala.org/techconnect/post/fear-no-longer-regular-expressions/ and then we could continue the discussion in #210 to look for another similar resource. Does that work for you?

kevintfrench commented 1 year ago

I see what you mean, @sharilaster though there are updates in other sections of library hat, there doesn't seem to be anything in the blog which, I'm sad to see, is also the case for ACRL Tech Connect. I switched out the link in favor of the one you found.

sharilaster commented 1 year ago

Thank you @kevintfrench!