Broken link to domain name list - Githubissues

LibraryCarpentry / lc-data-intro

Library Carpentry: Introduction to Working with Data (Regular Expressions)

https://librarycarpentry.org/lc-data-intro/

Other

29 stars 84 forks source link

Broken link to domain name list #219

Closed aforestsomewhere closed 4 months ago

aforestsomewhere commented 9 months ago

What is the problem?

In 2. Matching & Extracting Strings > Exercise finding email addresses using regex101.com > Finish the Expression, there is a broken link labelled "here" to common domain names directing to https://stats.research.icann.org/dns/tld_report/

Possible alternatives: https://data.iana.org/TLD/tlds-alpha-by-domain.txt https://publicsuffix.org/list/public_suffix_list.dat

Happy to submit a PR if it helps!

Location of problem (optional)

https://librarycarpentry.org/lc-data-intro/instructor/02-match-extract-strings.html#exercise-finding-email-addresses-using-regex101.com

kevintfrench commented 5 months ago

Thank you for noticing this @aforestsomewhere . Yes, I'd like to take you up on your offer to create a PR. Thank you!

aforestsomewhere commented 4 months ago

Submitted a PR there!