LibraryCarpentry / lc-data-intro

Library Carpentry: Introduction to Working with Data (Regular Expressions)
https://librarycarpentry.org/lc-data-intro/
Other
29 stars 84 forks source link

Update 02-match-extract-strings.md #222

Closed doujouDC closed 5 months ago

doujouDC commented 5 months ago

I have also added some comments via the issues feature. I am teaching this lesson for the first time in April. So, hopefully someone can respond before then

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

If any relevant discussions have taken place elsewhere, please provide links to these.

For more guidance on how to contribute changes to a Carpentries project, please review [the Contributing Guide](CONTRIBUTING.md) and [Code of Conduct](https://docs.carpentries.org/topic_folders/policies/code-of-conduct.html). Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.
github-actions[bot] commented 5 months ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/LibraryCarpentry/lc-data-intro/compare/md-outputs..md-outputs-PR-222

The following changes were observed in the rendered markdown documents:

 02-match-extract-strings.md | 6 +++---
 md5sum.txt                  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2024-03-17 13:32:24 +0000

kevintfrench commented 5 months ago

Thank you for identifying these issues @doujouDC I'm asking for a second set of eyes on the PR but it looks good to me.

kevintfrench commented 5 months ago

@doujouDC I've merged in your PR.

doujouDC commented 5 months ago

Hey Kevin, thanks for considering. I am really excited to teach this lesson for the first time. So thanks to you and all the maintainers.