search

LibraryCarpentry / lc-fair-research

Library Carpentry: FAIR Data & Software
https://librarycarpentry.org/lc-fair-research
Other
26 stars 24 forks source link

use remote theme #34

Closed tobyhodges closed 4 years ago

tobyhodges commented 4 years ago

This should be everything you need to start using the remote theme. As well as minor changes to .gitignore and _config.yml, the main differences are:

  1. structural information (_layouts, _includes, assets directories) are removed - after merging, this information will be drawn directly from the remote theme repo
  2. the make serve command, to build and serve pages locally, now uses Bundler (i.e. bundle exec jekyll serve rather than jekyll serve directly)

I have only tested this on my local machine and GitHub - maybe you'd like to pull this branch and confirm it works on your local setup before hitting the Big Green Button?

jezcope commented 4 years ago

Thanks @tobyhodges, this looks great and tidies things up nicely. I'll give it a try on my local machine ASAP and let you know if I run into any troubles.

tobyhodges commented 4 years ago

Note: just updated the branch to also remove .ruby-gemset & .ruby-version

tobyhodges commented 4 years ago

I'm going to ping @fmichonneau to respond to those questions, as I'm sure he'll do a better job than I could. François is on leave until Tuesday, though, so I'm afraid you'll likely have to wait for definitive answers.

fmichonneau commented 4 years ago

this looks good to me! Thank you all.

tobyhodges commented 4 years ago

Thanks François. I'll update the Makefile to match the latest version in carpentries/styles and then I think we're ready to go.

tobyhodges commented 4 years ago

The Makefile has been synced, so I think this is ready to be merged

libcce commented 4 years ago

Thanks @fmichonneau @tobyhodges!