search

LibraryCarpentry / lc-open-refine

Library Carpentry: OpenRefine
https://librarycarpentry.org/lc-open-refine/
Other
52 stars 133 forks source link

Broken URLK #278

Closed jeboden closed 1 year ago

jeboden commented 1 year ago

This link in Episode 5 Clustering is broken. https://github.com/OpenRefine/OpenRefine/wiki/Clustering-In-Depth

You can get the information here now. https://openrefine.org/docs/technical-reference/clustering-in-depth

jas58 commented 1 year ago

Thank you, @jeboden for making a suggestion to improve the Library Carpentry Open Refine lesson. May I share a tutorial on suggesting these edits in Github? Then we can see where you are in the episode.

yadlra commented 1 year ago

hi @jeboden , I'm happy to do this!

jeboden commented 1 year ago

Thank you! I am still learning Github.

yadlra commented 1 year ago

opened a pull request ready for review! https://github.com/LibraryCarpentry/lc-open-refine/pull/279

yadlra commented 1 year ago

opened a pull request ready for review! #279

ooops, because it's my first contribution I think it will be reviewed by the training progress team!?

ostephens commented 1 year ago

Thanks @yadlra @jeboden

@yadlra no additional checks needed from this side - the PR is all good - but if the training progress team need to review for the purposes of instructor / contributor training for you then you can still point them at the PR - they don't need to approve but just see that it happened OK etc.