LibraryCarpentry / lc-open-refine

Library Carpentry: OpenRefine
https://librarycarpentry.org/lc-open-refine/
Other
52 stars 134 forks source link

Test lesson with OpenRefine 3.7.4 #308

Open ostephens opened 1 year ago

ostephens commented 1 year ago

The lesson has currently been tested with OpenRefine 3.6.1. It would be good to check there are no changes needed for the current version (3.7.4)

This can be done by installing 3.7.4, working through the lesson and exercises and seeing if there are any situations where the outcome is different to those described in the lesson.

Any changes can be documented on this issue and then we can get the changes made. You are also welcome to suggest the changes directly using git/github (see this tutorial ) but there is no obligation to do this - working through the lesson using OpenRefine 3.7.4 and noting any issues is the key piece of work here :)

kthlnktng commented 1 year ago

I ran through the lesson and all exercises and was able to follow the instructions/exercises as expected. I did not see any difference with respect to available functions/options (or the naming of these functions/options), or the generated results.

I only noted one difference, which was within the "6. Working with columns and sorting" episode. In the Sorting data section of the episode, it is not detailed that you have to set the sorting options before the Sort button appears at the top of the grid. Example screenshot seen below:

image

This may not be new functionality with 3.7.4, perhaps just a step that is not detailed in this part of the episode.

Here are my setup details. - Tested on OpenRefine 3.7.4, [downloaded from here](https://openrefine.org/download) - Running on Mac OS Ventura Version 13.5 (22G74) - Using Firefox 115.0.3 (64-bit) - Following https://librarycarpentry.org/lc-open-refine - Episodes "Summary and setup" through "13. Looking up data"

While reviewing the lesson, I found some unrelated things that should be addressed. (Minor changes like formatting/broken links, etc.)

For reference, here is that list of minor changes to make. _Issues unrelated to OpenRefine version 3.7.4_: Summary and setup: - broken link for "[Blog posts on using OpenRefine from Owen Stephens](https://www.meanboyfriend.com/overdue_ideas/tag/openrefine/?orderby=date&order=ASC)" - website does not load 2. Importing data into OpenRefine - Under [Create your first OpenRefine Project...](https://librarycarpentry.org/lc-open-refine/02-importing-data.html#create-your-first-openrefine-project-using-provided-data), step 7 does not have "Trim leading & trailing whitespace from strings" in backticks for code notation 4. Faceting and filtering - Under [Filters](https://librarycarpentry.org/lc-open-refine/04-faceting-and-filtering.html#filters), the [link for regular expressions leads to "page not found."](https://librarycarpentry.org/lc-data-intro/01-regular-expressions/) - Having the trailing slash leads to the page not being found. https://librarycarpentry.org/lc-data-intro/01-regular-expressions works. 6. Working with columns and sorting - in [Reordering columns](https://librarycarpentry.org/lc-open-refine/06-working-with-columns.html#reordering-columns), `All`, `Edit columns` > `Re-order / remove columns` are not in code notation - in [Renaming columns](https://librarycarpentry.org/lc-open-refine/06-working-with-columns.html#renaming-columns), `Edit column` > `Rename this column` are not in code notation 10. Transforming Strings, Numbers, Dates and Booleans - [Reformat the date](https://librarycarpentry.org/lc-open-refine/10-data-transformation.html#reformat-the-date), inconsistent use of '' and ``, so some items are not in code notation 11. Transformations - Handling Arrays - Within [Arrays](https://librarycarpentry.org/lc-open-refine/11-using-arrays-transformations.html#arrays) section, link to "Working with Data is broken. Need to remove trailing "/index.html", leaving https://librarycarpentry.org/lc-open-refine/03-working-with-data - Within [Arrays](https://librarycarpentry.org/lc-open-refine/11-using-arrays-transformations.html#arrays) section, ` [“crystal structure”, “clozapinium”, “molecular configuration”, “hydrogen bonding”, “supramolecular assembly”, “Chemistry”, “QD1-999”]` is not within backticks, so no code notation - [Reverse author names](https://librarycarpentry.org/lc-open-refine/11-using-arrays-transformations.html#reverse-author-names) step 7 should have `true` within backticks 13. Looking Up Data - [Reverse author names ](https://librarycarpentry.org/lc-open-refine/13-looking-up-data.html#looking-up-data-from-a-url) needs backticks for `Edit column->Add column by fetching URLs.` - https://librarycarpentry.org/lc-open-refine/13-looking-up-data.html#retrieving-journal-details-from-crossref-via-issn has some steps that need backticks for options/code - https://librarycarpentry.org/lc-open-refine/13-looking-up-data.html#reconcile-publisher-names-with-viaf-ids needs some backticks

I can open up a PR for these items.

ostephens commented 1 year ago

Brilliant - thanks so much @kthlnktng . Please go ahead with the PR and I'll review! If you could include updating the information to say the lesson has been tested with 3.7.4 where it currently says 3.6.1 that would be brilliant

Thanks

Owen

jas58 commented 4 months ago

333 updated version verification to 3.7.7 in January 2024

342 mentions