LibraryCarpentry / lc-open-refine

Library Carpentry: OpenRefine
https://librarycarpentry.org/lc-open-refine/
Other
52 stars 134 forks source link

fix broken link to Working with Data #327

Closed maneesha closed 8 months ago

maneesha commented 9 months ago

Broken link to "Working with Data" from https://librarycarpentry.org/lc-open-refine/aio.html#arrays

github-actions[bot] commented 9 months ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/LibraryCarpentry/lc-open-refine/compare/md-outputs..md-outputs-PR-327

The following changes were observed in the rendered markdown documents:

 11-using-arrays-transformations.md | 3 +--
 md5sum.txt                         | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2023-12-15 15:32:30 +0000

jas58 commented 9 months ago

It looks like @maneesha was using the All in One view (which I use as an instructor, too). Though it's actually the part in episode 12, on exporting data. Is that correct?

And @ostephens is verifying the link should go towards: https://librarycarpentry.org/lc-open-refine/03-working-with-data.html#choosing-a-good-separator

Also, there's an extra full stop at the end of that sentence.

Will editing the aio file also update the right episode file?

As an internal reference, does this need the .md instead of .html? I don't recall how that works with hashtags to subsections.

ostephens commented 9 months ago

Though it's actually the part in episode 12, on exporting data. Is that correct?

Just for clarity it's in episode 11 (which you link to)

Will editing the aio file also update the right episode file?

It would not - but the edit has been done on the correct file episodes/11-using-arrays-transformations.md so it is being done in the right place as far as I can see

As an internal reference, does this need the .md instead of .html? I don't recall how that works with hashtags to subsections.

Good catch - yes this should use the internal link syntax and that will work with the hash / fragment as well. See https://carpentries.github.io/sandpaper-docs/episodes.html#internal-links