LibraryCarpentry / lc-open-refine

Library Carpentry: OpenRefine
https://librarycarpentry.org/lc-open-refine/
Other
52 stars 134 forks source link

Update supported and tested version on Getting Ready (setup.md) #333

Closed emcaulay closed 7 months ago

emcaulay commented 7 months ago

I updated the version that this lesson is tested with from 3.6.1 to 3.7.7.

I taught this lesson through episode 9, and everything worked correctly with the latest version of Open Refine that I had downloaded (3.7.7).

github-actions[bot] commented 7 months ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/LibraryCarpentry/lc-open-refine/compare/md-outputs..md-outputs-PR-333

The following changes were observed in the rendered markdown documents:

 md5sum.txt | 2 +-
 setup.md   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2024-01-17 22:49:11 +0000

emcaulay commented 7 months ago

@jas58 , I mentioned this PR during our Maintainers Meeting today, and I was able to make the PR and submit it. Hopefully it's helpful, but as I didn't teach all the way through the lesson, I can understand it you want it to be more completely tested.

ostephens commented 7 months ago

Thanks so much for doing this @emcaulay I've checked the remainder of the lesson with 3.7.7 and it all works so I think we are good to merge this