Closed r0man-ist closed 2 months ago
Thank you for your pull request :smiley:
:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.
If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
:mag: Inspect the changes: https://github.com/LibraryCarpentry/lc-open-refine/compare/md-outputs..md-outputs-PR-349
The following changes were observed in the rendered markdown documents:
md5sum.txt | 2 +-
setup.md | 19 +++++++------------
2 files changed, 8 insertions(+), 13 deletions(-)
:stopwatch: Updated at 2024-06-18 13:14:03 +0000
I don't think there is the need for any further changes but just for complete clarity, OpenRefine itself does still offer It also the "windows without embedded java" option but only via Github and not on the download page. I mention only for completeness and do not suggest any further changes to the lesson
You're absolutely right (although there does not seem to be a version without java for win from 3.8 onwards). I just thought since the lesson is referring to the download-page it would be confusing to mention things that are nowhere to be found there. Maybe I should have raised this as an issue first...
I might have been too fast to approve. Thanks for starting the PR. I'll move a bit slower.
On Thu, Jun 20, 2024, 3:25 PM r0man-ist @.***> wrote:
You're absolutely right (although there does not seem to be a version without java for win from 3.8 onwards). I just thought since the lesson is referring to the download-page it would be confusing to mention things that are nowhere to be found there. Maybe I should have raised this as an issue first...
— Reply to this email directly, view it on GitHub https://github.com/LibraryCarpentry/lc-open-refine/pull/349#issuecomment-2181499880, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMT5MX5IG4EC3PLZRZO27PDZIM3EFAVCNFSM6AAAAABJQAP7YGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBRGQ4TSOBYGA . You are receiving this because you modified the open/close state.Message ID: @.***>
@jas58 I think the outcome was the same - this is the right change so I don't think you were too hasty - good to get the update done quickly :)
The OR download page no longer uses the term "kit" for different packages. It also no longer offers a "traditional windows kit" without embedded java, as far as I can see.