search

LibraryCarpentry / lc-open-refine

Library Carpentry: OpenRefine
https://librarycarpentry.org/lc-open-refine/
Other
52 stars 133 forks source link

Episode 6: Working with columns and sorting #94

Closed fionaglasgow closed 2 years ago

fionaglasgow commented 5 years ago

Kia ora,

As part of the checkout process I propose a minor change to Chapter 6: Working with columns and sorting.

I suggest a minor change of wording relating to re-order vs reorder:

You can re-order the columns by clicking the drop-down menu at the top of the first column (labelled ‘All’), and choosing Edit columns->Re-order / remove columns …

You can then drag and drop column names to re-order the columns, or remove columns completely if they are not required.

to be replaced by:

You can reorder the columns by clicking the drop-down menu at the top of the first column (labelled ‘All’), and choosing Edit columns->Re-order / remove columns …

You can then drag and drop column names to reorder the columns, or remove columns completely if they are not required.

Motivation for suggested change:

There are two variations on "reorder" in use on this page, which, while minor, is inconsistent.

It might be worth having a discussion to see which way it goes, ie, the "reorders" could be changed to "re-orders", given that that is how it is spelled in OpenRefine, even though I don't believe that is technically grammatically correct. The remainder of the lesson uses reorder, for what it's worth.

Fiona Glasgow Research Support Librarian University of Otago

ostephens commented 5 years ago

Thanks @fionaglasgow

I agree this should be consistent throughout and that reorder (non-hyphenated) is the correct, or at least more common, form.

Apart from where the text is specifically reproducing the terminology from OpenRefine (eg directing the user to a menu) I think we should use ‘reorder’

A PR to this effect would be welcome