search

LibraryCarpentry / lc-shell

Library Carpentry: The UNIX Shell
https://librarycarpentry.org/lc-shell/
Other
31 stars 85 forks source link

Remove hidden directory from data #235

Open ndporter opened 1 year ago

ndporter commented 1 year ago

The shell-lesson-data.zip file includes a hidden __MACOSX directory that is visible when running ls in Git Bash (and thus potentially confusing to learners. Ideally, the datafile should be updated to remove this extra cognitive load (and filesize) unless there is a reason it needs to be there.

jmjamison commented 1 year ago

I think that the removing the __MACOSX folder would impact the MacOS users and require separate lesson files. That's my guess, I'm a Windows/Linux user so anything specific to MacOS is a guess for me.

That said I don't think a brief explanation would throw the class off course. It might be helpful for new users to know what to ignore based on their OS.

contents directory

emcaulay commented 1 year ago

I think the __MACOSX file is not necessary. But I can test if you want me to.

jmjamison commented 1 year ago

@emcaulay If you could test this out that would be very helpful. Not using MacOS I have no idea if that file is necessary. Thank you.

emcaulay commented 1 year ago

I tested it, and that part of the file is not necessary. I made a new zip and shared with @jmjamison -- and I think it's free of Mac detritus. Jamie will review next week.

emcaulay commented 1 year ago

(I shared a new zip with her via Slack since I can't upload the zip to the repo)

jmjamison commented 1 year ago

And I learned something new about MacOS files.

kaitlinnewson commented 1 year ago

@jmjamison has this new file been update in this repo? I didn't notice any pull request for it.