LibraryCarpentry / lc-shell

Library Carpentry: The UNIX Shell
https://librarycarpentry.org/lc-shell/
Other
29 stars 86 forks source link

Loop image doesn't match lesson content #247

Open scottcpeterson opened 1 year ago

scottcpeterson commented 1 year ago

What is the problem?

The code on the Loop image is wrong. It is currently,

for filename in *.dat do echo cp "$filename" backup_"$filename" done

When it should be

for filename in *.dat do echo "$filename" cp "$filename" backup_"$filename" done

Location of problem (optional)

Line 175 {alt='For Loop in Action'}

https://librarycarpentry.org/lc-shell/04-loops.html#for-loop-exercise

scottcpeterson commented 1 year ago

Actually, the Stdout is correct in the image, it is just a confusing image as it doesn't follow the example in the lesson.

kaitlinnewson commented 1 year ago

Hi @scottcpeterson, I've reopened this issue as I think what you've pointed out about the image not matching the lesson makes sense and is worth resolving - we should update the image so that it more closely matches the code in the lesson.