LibraryCarpentry / lc-sql

Library Carpentry: SQL
https://librarycarpentry.org/lc-sql/
Other
13 stars 37 forks source link

Lesson Contribution - Join types; JN #147

Closed Talishask closed 2 years ago

Talishask commented 2 years ago

I'm a member of The Carpentries Core Team and I'm submitting this issue on behalf of another member of the community. In most cases, I won't be able to follow up or provide more details other than what I'm providing below.


Line 35 Join Diagram for Example left-join-articles-journals_40.png is to visualize the join example in lines 24-27, which however is a (inner) join; I propose to change the PNG accordingly.

Line 121, There are different types of joins which you can learn more about at SQL Joins Explained. the web-link http://www.sql-join.com/sql-join-types resolves to https://www.talend.com/

Instructions Thanks for contributing! :heart: If this contribution is for instructor training, please email the link to this contribution to instructor.training@carpentries.org so we can record your progress. You've completed your contribution step for instructor checkout by submitting this contribution! Keep in mind that **lesson maintainers are volunteers** and it may take them some time to respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org. You may delete these instructions from your comment. \- The Carpentries
jyssy commented 2 years ago

@Talishask Thank you for your PR.