search

LibraryCarpentry / lc-sql

Library Carpentry: SQL
https://librarycarpentry.org/lc-sql/
Other
13 stars 37 forks source link

Edit unquoted hyphens in Creating... lesson #167

Open kevinatpenn opened 11 months ago

kevinatpenn commented 11 months ago

How could the content be improved?

In the first demo code chunk, the - in ISSN-L causes an error (Result: near "-": syntax error) when running. Suggest changing to ISSNL or comparable.

Which part of the content does your suggestion apply to?

episodes/09-create.md

kevinatpenn commented 11 months ago

Just noticed the unquoted hyphen issue again in the second-to-last code chunk (UPDATE journals SET ISSN-L = 2076-2615, ISSNs = 2076-2615 WHERE id = 3;). Adding double quotes seems like the better solution here: UPDATE journals SET "ISSN-L" = "2076-2615", ISSNs = "2076-2615" WHERE id = 3;

In case it helps, I'm on Windows 10 (build 19043.2364), running the following as portable: DB Browser for SQLite Version 3.12.2 Built for x86_64-little_endian-llp64, running on x86_64 Qt Version 5.12.8 SQLCipher Version 4.4.0 community (based on SQLite 3.34.1).