search

LibraryCarpentry / library-python

Python for Librarians
https://librarycarpentry.github.io/library-python/
Other
21 stars 17 forks source link

Clean up Windows, Mac and Linux setup pages #23

Closed richyvk closed 8 years ago

richyvk commented 8 years ago

Noticed a lot of the html was not right on these pages causing the setup page to not render properly, so tidied up tags etc.

mkuzak commented 8 years ago

@richyvk Thank you. As you can see in the discussion in issue #17 the rendering is an issue, but actually the content that is rendered is not right. I'll wait for @c-martinez to fix it first

richyvk commented 8 years ago

No problem. Should close this then? I was curious about the code. Are these pages (windows.html etc) generated by Jekyll or written directly by us? There were loads of for missing closing tags - that was the main reason the page whole page wasn't rendering properly.

c-martinez commented 8 years ago

@mkuzak -- PR for #17 sent, please check.

@richyvk -- They are generated by us. I think it should render ok now. Sorry, was a bit careless on the previous iteration. Hope it is better now.

richyvk commented 8 years ago

@c-martinez Thanks for the explanation :)

mkuzak commented 8 years ago

This has been solved through the pull request #28 by @c-martinez . Closing.