search

LibraryCarpentry / library-python

Python for Librarians
https://librarycarpentry.github.io/library-python/
Other
21 stars 17 forks source link

Inline code isn't being highlighted fully (on my computer) #5

Closed brendam closed 8 years ago

brendam commented 8 years ago

This is what it looks like in the ecology lesson:

ecology-lesson

and this is what I'm seeing locally (might just be a difference with Github rendering vs local)

library-python

Without the bounding box it is hard to distinguish the = as code.

brendam commented 8 years ago

Not being highlighted on github either

mkuzak commented 8 years ago

This is how the styling works in new template. You can see it in other Software Carpentry lessons using new template. DC Python lesson uses old template.

brendam commented 8 years ago

@mkuzak the software carpentry lesson example seems to have inline code with a light gray background, where our one is just showing a fixed face font - can you please check? I think the current highlighting is too minimal, needs to be a bit clearer what is code and what is text.

mkuzak commented 8 years ago

@brendam can you point me to example of it in software carpentry lesson?

brendam commented 8 years ago

ok, now I feel like I was seeing things. Was sure I saw some pale gray background this morning, not seeing it now. So you are right, we seem to be using the default - where should I discuss whether that default is good?

mkuzak commented 8 years ago

That's ok, I do agree grey background makes it more stand out, but that's what we get. If you want it to be changed in LC only I'd mention it at gitter chat, otherwise (SC/DC wide) on software carpentry discussion mailing list.