LibraryOfCongress / api.congress.gov

congress.gov API
642 stars 39 forks source link

(member API): Ben Sasse still marked as `"currentMember": true,` #137

Closed ryparker closed 3 months ago

ryparker commented 1 year ago

Ben Sasse resigned from the Senate on January 8, 2023, however the API is still returning him as a current member.

Reproduce: curl 'https://api.congress.gov/v3/member/S001197?format=json&api_key=<API_KEY>'

Returns:

{
    "member": {
        "addressInformation": {
            "city": "Washington",
            "district": "DC",
            "zipCode": 20510
        },
        "bioguideId": "S001197",
        "birthYear": "1972",
        "cosponsoredLegislation": {
            "count": 557,
            "url": "https://api.congress.gov/v3/member/S001197/cosponsored-legislation"
        },
        "currentMember": true,
        "depiction": {
            "attribution": "<a href=\"http://www.senate.gov/artandhistory/history/common/generic/Photo_Collection_of_the_Senate_Historical_Office.htm\">Courtesy U.S. Senate Historical Office</a>",
            "imageUrl": "https://www.congress.gov/img/member/s001197_200.jpg"
        },
        "directOrderName": "Ben Sasse",
        "firstName": "Ben",
        "honorificName": "Mr.",
        "invertedOrderName": "Sasse, Ben",
        "lastName": "Sasse",
        "partyHistory": [
            {
                "partyAbbreviation": "R",
                "partyName": "Republican",
                "startYear": 2015
            }
        ],
        "sponsoredLegislation": {
            "count": 182,
            "url": "https://api.congress.gov/v3/member/S001197/sponsored-legislation"
        },
        "state": "Nebraska",
        "terms": [
            {
                "chamber": "Senate",
                "congress": 114,
                "endYear": 2017,
                "memberType": "Senator",
                "startYear": 2015,
                "stateCode": "NE",
                "stateName": "Nebraska"
            },
            {
                "chamber": "Senate",
                "congress": 115,
                "endYear": 2019,
                "memberType": "Senator",
                "startYear": 2017,
                "stateCode": "NE",
                "stateName": "Nebraska"
            },
            {
                "chamber": "Senate",
                "congress": 116,
                "endYear": 2021,
                "memberType": "Senator",
                "startYear": 2019,
                "stateCode": "NE",
                "stateName": "Nebraska"
            },
            {
                "chamber": "Senate",
                "congress": 117,
                "endYear": 2023,
                "memberType": "Senator",
                "startYear": 2021,
                "stateCode": "NE",
                "stateName": "Nebraska"
            },
            {
                "chamber": "Senate",
                "congress": 118,
                "endYear": 2023,
                "memberType": "Senator",
                "startYear": 2023,
                "stateCode": "NE",
                "stateName": "Nebraska"
            }
        ],
        "updateDate": "2023-01-26T16:10:43Z"
    },
    "request": {
        "bioguideId": "s001197",
        "contentType": "application/json",
        "format": "json"
    }
}
mnewatloc commented 1 year ago

We've investigated this issue and are creating a ticket to fix it.

ryparker commented 8 months ago

It looks like this may have been fixed however it may have introduced a new bug. It looks like when currentMember is set to false the API does not return the prop at all. I had expected it to return "currentMember": false in this scenario.

mnewatloc commented 8 months ago

We have created a ticket to investigate this.