assign values to argument namespace instead of parser

LibraryOfCongress / bagit-python

Work with BagIt packages from Python.

http://libraryofcongress.github.io/bagit-python

218 stars 85 forks source link

assign values to argument namespace instead of parser #108

Closed fkloft closed 5 years ago

fkloft commented 6 years ago

Currently, metadata items are assigned to a dict that is stored as an attribute of the argument parser. The proper solution would be to assign the dict to the argument namespace, which is also the way the Python docs suggest.

Also, the generation of default values directly on the argument namespace is suppressed to not litter it with None values.

coveralls commented 6 years ago

Coverage decreased (-82.04%) to 0.0% when pulling 55071cf06837d805ea200cbb5901b52d899dab6e on fkloft:argparser into db0e3dc2d5fb8276a8b24e305fbdb524c22ee12a on LibraryOfCongress:master.

acdha commented 5 years ago

It looks like most of the changed lines are whitespace-related. Can you run your branch through Black first?

fkloft commented 5 years ago

Sorry, this was an old PR. When I tried to merge the current master, I accidentally reverted some whitespace related changes from master. I rebased my commits onto master which fixed the whitespace issues.