search

LibraryOfCongress / bagit-python

Work with BagIt packages from Python.
http://libraryofcongress.github.io/bagit-python
218 stars 85 forks source link

Restore support for Python 2.7.0-2.7.8 #123

Closed nsoranzo closed 5 years ago

nsoranzo commented 5 years ago

hashlib.algorithms_guaranteed was introduced only in Python 2.7.9, see https://docs.python.org/2.7/library/hashlib.html#hashlib.algorithms_guaranteed

Ubuntu 14.04 LTS (which will be supported until April 2019) still provides python 2.7.5 and therefore needs this fix.

Tested on python 2.7.3, 2.7.5, 2.7.12 and 3.5.3.

xref. https://github.com/LibraryOfCongress/bagit-python/pull/110/files/1e8c9102ca004ffe19984ac2eceaee8f0d616dfd#r238885995

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-1.3%) to 82.252% when pulling 6b25e39bc92f48468439ecd4316d6f9cde741d59 on nsoranzo:patch-1 into c39b650a80837a1d32314599143d0b5b04159248 on LibraryOfCongress:master.

acdha commented 5 years ago

I merged this since it's small but also added a flag for the cleanup in #102

nsoranzo commented 5 years ago

Thanks @acdha!