search

LibraryOfCongress / bagit-spec

8 stars 7 forks source link

tag manifests should be complete #19

Closed stain closed 6 years ago

stain commented 6 years ago

.. and can't list tag manifests for obvious reasons.

If you agree we can change the &should; to a &must; to make it consistent with payload manifests. Then we might need a BagIt 1.0 clause here as well; as well as clarifying if bagit.txt is included or not.

justinlittman commented 6 years ago

@acdha thoughts?

johnscancella commented 6 years ago

I think we need to mention that you should not list any tag manifest. Otherwise LGTM 👍

stain commented 6 years ago

@johnscancella right - I did think of that (mistake done once in manual bagit-code):

Each tag manifest &must; list every payload manifest, but &must-not; list any tag manifests.

stain commented 6 years ago

or perhaps we can move that phrasing around to the next line?

Each tag manifest &must-not; list any tag manifests, but &should; list the remaining tag files present in the bag.

johnscancella commented 6 years ago

Made the requested changes and merged manually