LibraryOfCongress / chronam

This software project is no longer being actively developed at the Library of Congress. Consider using the Open-ONI (https://github.com/open-oni) fork of the chronam software. Project mailing list: http://listserv.loc.gov/archives/chronam-users.html.
71 stars 34 forks source link

GitHub Action to lint Python code #252

Closed cclauss closed 1 year ago

cclauss commented 1 year ago

Test results: https://github.com/cclauss/chronam/actions

acdha commented 1 year ago

My concern with this is that the problem isn't really running the linters but someone needing time for major upgrades — more than pyupgrade + django-upgrade are going to handle automatically.

cclauss commented 1 year ago

We can add things to pre-commit over time.

acdha commented 1 year ago

I think that makes sense. For example, we could do a simple pyupgrade pass and then enable that hook so we don't train everyone to think of jobs failing as normal.

Thanks for the work you've been contributing!