search

LibreBooking / app

Repository for the last open source version of Booked Scheduler. The "develop" branch contains the most current working code of the project and should be considered beta. The "master" branch is the most current stable release of BookedScheduler. Please read doc/README.md for further details.
GNU General Public License v3.0
382 stars 225 forks source link

users and recourses import and export #180

Open kkrueger61 opened 1 year ago

kkrueger61 commented 1 year ago

I installed local the developer branch and tried to export from an online instance (version 2.8.5.5) the resources and to import them into my local installation -> everything was fine without a problem. Then I tried the same with the users but when I tried to import them, the error was "no first row or empty file" The users.csv was not empty and had a first row (in German). The entries where separated with quotation marks and the fields separated with comma. In the downloadable draft the first row was in english with no quotation marks around the entries. First I saved the users.csv without quotation marks but the error was the same. Then I edited the file and changed the german in the first row into the english from the draft file -> now I could import the users. The default file for the resources looks the same : english without quotation marks. There must be a difference in the code between the two import/export function. Grüße Katja

BatBat123 commented 1 year ago

Dear Katja,

Thank you for sharing your experience with importing users into your local installation. It seems that you encountered an issue with the import process, where the error message "no first row or empty file" appeared even though your users.csv file had a valid first row in German.

However, I would like to inform you that a new version of the application has been released (version X.X.X). This new version includes several bug fixes and improvements, which may have resolved the problem you encountered during the import.

I recommend giving it another try with the latest version of the application. Ensure that you have the correct users.csv file, and make sure that the format of the file matches the expected format for the import process. If any issues persist, please consult the documentation or reach out ASAP

jplagostena commented 1 year ago

Hi everyone, this bug is still reproducible and it happens when you try to import a file exported in another language. The export template translates the column names but the importer does not take this into account, so it can't find the headers properly.

This code is in ResourceImportCsv in the GetHeaders method.

imagen

Regarding the fix: one quick fix to make in the base code is just export the column names in english without translation. The real fix is to have a translate engine in the import, but it looks a bit harder.