LibreBooking / app

Repository for the last open source version of Booked Scheduler. The "develop" branch contains the most current working code of the project and should be considered beta. The "master" branch is the most current stable release of BookedScheduler. Please read doc/README.md for further details.
GNU General Public License v3.0
371 stars 220 forks source link

Standard schedule lag when loading reservations #371

Closed ramartins02 closed 1 month ago

ramartins02 commented 1 month ago

Previous pull request (#323) may be causing the system to lag when there are to many reservations to load on the standard schedule (#370).

A new configuration is now available that lets the admin choose if he wishes to have the full label with all the text shown (true) or not (false).

With the full label it will take more time to load than the default 41px sized label. The admin should choose the preferred way based on the possible/max number of reservations the schedules have.

$conf['settings']['reservation']['show.full.label'] = 'false';

JohnVillalovos commented 1 month ago

@ramartins02 Thanks for working on this.

I applied the patch locally but I am not noticing any improvements ☹️

I have three filters set which narrow it down to two systems, and showing one week.

I put in a console.time() and console.timeLog() at the start and end of the renderEvents() method.

This is the result. And yes on average full.label = false took longer for my 5 attempts.

And when you say "label", what does that mean? Does that mean the "name" of the resource?

As a note, I did delete all files in tpl_c/* after making the config.php change. Not sure if that is required or not.

Now one thing might be an issue for me, is that I am running over a VPN to connect to the LibreBooking server.