search

LibreBooking / app

Repository for the last open source version of Booked Scheduler. The "develop" branch contains the most current working code of the project and should be considered beta. The "master" branch is the most current stable release of BookedScheduler. Please read doc/README.md for further details.
GNU General Public License v3.0
406 stars 242 forks source link

Resurrect unit tests #408

Closed hakito closed 2 months ago

hakito commented 2 months ago

The unit tests seem to be broken for quite a long time. This makes it difficult to contribute to the project without breaking something essential.

So this PR is focused on fixing the phpunit tests. It covers the following changes.

I also adapted the script part in the composer.json. However without the .phive environment the lint call will fail because of the missing tools directory.

Actually I'd suggest to get rid of the .phive stuff.

JohnVillalovos commented 2 months ago

I haven't reviewed but really like the idea of getting working unit tests. Thank you!

effgarces commented 2 months ago

Great work, I really wanted to bring back unit tests, but it was really in my list os priorities, so thank you for your contribution