Unit tests fails during dailight saving change period

LibreBooking / app

Repository for the last open source version of Booked Scheduler. The "develop" branch contains the most current working code of the project and should be considered beta. The "master" branch is the most current stable release of BookedScheduler. Please read doc/README.md for further details.

GNU General Public License v3.0

403 stars 241 forks source link

Unit tests fails during dailight saving change period #451

Open hakito opened 2 weeks ago

hakito commented 2 weeks ago

The test ScheduleTotalConcurrentReservationsRuleTest::testChecksEachInstanceOfASeries fails on 2nd November 2024.

The reason seems to be that on line

https://github.com/LibreBooking/app/blob/7a763d98e52942ea3df7983133342d76b2bebac0/Domain/ReservationSeries.php#L311

the calculated dates are calculated for the time zone of the 'booker' which is New York.

The DateRange class or Date seems to have timezone based conversions, but something must go wrong.