LibreBooking / docker

Librebooking as a docker container
GNU General Public License v3.0
11 stars 12 forks source link

the Mexico timezone error occurs again in v2.8.6 #22

Closed uebmaster closed 1 year ago

uebmaster commented 1 year ago

I wanted to test the upgrade process, so I did a fresh install of v2.8.5, checked the time zone and it was fine, added a resource, user and reservation to test that they persisted when upgrading.

the update process ran without issue, but when reviewing the server settings I saw that the time had changed to UTC +00:00, when before updating it was fine (America/Mexico_City).

I guess it must be the same as the previous time, the php.ini, because in the application configuration the time zone is set to America/Mexico_City

I hope you can make the correction soon, while I work with 2.8.5

Greetings.

image

image

colisee commented 1 year ago

Hola @uebmaster ,

Well done! Actually, the problem occurs even without upgrading. If you perform:

sudo docker-compose down
sudo docker-compose up --detach

then the server will revert to UTC.

I spotted the error in entrypoint.shand I will keep you posted.

Saludos.

colisee commented 1 year ago

I believe I fixed the error. Before I push the fix into production, could you please make a test on your side as well, by performing the following actions:

# Clone the develop branch of the github repository
git clone -b develop https://github.com/librebooking/docker.git librebooking-docker

# Rebuild the docker image on your host
sudo docker image rm librebooking/librebooking:2.8.6
pushd librebooking-docker
LB_RELEASE=2.8.6
sudo docker build \
  --tag librebooking/librebooking:${LB_RELEASE} \
  --build-arg LB_RELEASE=${LB_RELEASE} \
  .
popd

# Repeat the upgrade procedure from 2.8.5 to 2.8.6

# Check and report the results

Saludos.

uebmaster commented 1 year ago

@colisee It works!

although I think that I messed up the installation that I had previously, because by copying and pasting I put the name of the volume that I had in the other installation and not the one of the installation with which I was testing :/

colisee commented 1 year ago

Thank you @uebmaster

I pushed the fix into production and the new docker image to the docker registry.