Closed Jacq closed 1 year ago
Hi @Jacq
Thank you very much for your PR.
entrypoint.sh
regarding the linking of file config.php
. I am obviously OKLB_ENV
that controls the source of the file config.php
, as per you docker-compose.yml
. I am OK with it, but I must then adapt file entrypoint.sh
to use this new variable.env
and docker-compose.yml
to the repository. In this case, I am not OK, because I assume this is an "infrastructure" decision rather than a development one. I prefer to give docker-compose.yml examples; because in the end, it is the responsibility of the user to decide how to run the image (some might use CLI or Kubernetes rather than compose)Please note that @effgarces should, at one point of time, decide whether to keep docker artifacts in the app repository, or not.
Cheers.
@Jacq , if you wish you could add the changes related to the new variable LB_ENV and submit an amended PR:
entrypoint.sh
to control the creation of file config.php
based on LB_ENV. Please create a new constant DFT_ENV with a value of "prod"RUN.md
Otherwise, I will take care of it.
Cheers
I finally fix the issue #43 myself and created a new release 2.0.1
Ì will add the new container variable LB_ENV
in a new minor release
Test setup for the new docker image to describe a full configuration similar top the docker-compose.yml in the app repo.