LibreCAD / docs

This is LibreCAD's documentation repository for multiple version and format documents, supported by readthedocs.io
https://docs.librecad.org/
10 stars 22 forks source link

Description of ESC key behavior in "The Command Line" is wrong #101

Open lordofbikes opened 3 years ago

lordofbikes commented 3 years ago

I got notice of this issue by LibreCAD issue LibreCAD/LibreCAD#1373 In the manual the old 2.1.3 behavior is described. For 2.2.0 the ESC behavior changed, all operations are fully canceled on first ESC press. The behavior of right click was kept and is still like the described ESC behavior. Right click goes back one step in chained actions like trimming or 2-point line drawing. ESC cancel these on first press. Maybe this has to be described better on some other place, e.g. at Using a Mouse and Using the Keyboard in Fundamentals.

Source reference: https://github.com/LibreCAD/docs/blob/master/guides/cmdline.rst#command-line-functions

Maybe we should wait for a conclusion in the mentioned LibreCAD issue, if we keep current behavior or switch back to 2.1.3 style. Anyhow, it seems that the right click behavior in active operations is not described at all yet.

lordofbikes commented 3 years ago

Commenting on LibreCAD/LibreCAD#1373 I found out that it depends, if ESC is pressed in active command line or not. When the command line has focus, e.g. when entering coordinates, ESC behaves like described. It cancel the current action, not the whole operation. Sadly this looses focus and only CTRL-M can put focus back to command line. When command line is not active, e.g. during trimming with mouse, ESC cancel operation on first hit.