lordofbikes
commented
3 years ago @nyalldawson please, don't be cross with me, but I have to put a break on your efforts for the moment. I haven't looked at your pull requests #43 and following yet. But my worry is, that it will become just more pain to merge them than the last series. I communicated in #28 already, that I merged all pull requests till #42 and I merged the mergeLibreCAD2 branch too. Regardless you pushed to some already merged branches. But no problem, I think I can cherry-pick them.
For the new pull request, following this one, I'll have a look later, when I have finished my changes. So I recommend to wait now for my push, that you can continue from a more up to date base.
I understand your intention of keeping things separate in branches. But with this amount of changes, touching the same file in multiple branches, makes merging a pain, lots of conflicts. So we possibly find a better way to handle this with less efforts. I have some ideas, but no time yet, must run.
nyalldawson
Given the heavy improvements currently being done, it makes sense to improve the CI first :partying_face:
This PR:
https://github.com/qgis/libdxfrw also has a workflow for periodic builds using coverity scan, but that workflow isn't so easy to port (requires a repo maintainer to add the private token for the build submission, and will first require coverity setup for this repo. I can do that if desired, but I'll still need someone to add the private token to this repo)