Recently test 09-serializer-json-string started failing

LibreCat / Catmandu-DBI

A Catmandu::Store plugin for DBI based interfaces

Other

0 stars 1 forks source link

Recently test 09-serializer-json-string started failing #35

Open andk opened 2 years ago

andk commented 2 years ago

@charsbar, could you please have a look at this? It seems to be a regression.

The matrix shows several fail reports: http://matrix.cpantesters.org/?dist=Catmandu-DBI%200.11

I could reproduce this report with a perl that has:

no JSON::XS
JSON 4.06 or 4.07
JSON::PP 4.08, 4.09, or 4.10 (while 4.06 and 4.07 produced a PASS)

Let me know if you need more details.

charsbar commented 2 years ago

@andk, the failure was introduced by https://github.com/makamaka/JSON-PP/pull/59 . I can revert it, but what do you think about the issue (https://github.com/makamaka/JSON-PP/issues/58) it tried to solve, and the test https://github.com/LibreCat/Catmandu-DBI/blob/master/t/09-serializer-json-string.t#L34 that is currently failing?

andk commented 2 years ago

Ahhh, I hadn't looked closely enough at the test. Indeed, the test tests the wrong thing. There is no requirement to upgrade this string because it is, per definition, a non-encoded Unicode string. Since it does not contain any character > 255, it can be kept as it is. It's not valid to demand that it be upgraded. So the test

    ok(utf8::is_utf8($data));

is testing something that nobody has promised. I agree with you, that this isn't a regression. Thanks, @charsbar ++ for your patience!