LibreCat / Catmandu-Identifier

Namespace for handling/fixing identifier, e.g. ISBN, ISSN
https://metacpan.org/release/Catmandu-Identifier
Other
2 stars 2 forks source link

t/fix-isbn_versions.t started to fail #16

Closed eserte closed 4 years ago

eserte commented 4 years ago

My smokers started to report the following failure:

#   Failed test 'non-convertible isbn 13 versions'
#   at t/fix-isbn_versions.t line 44.
#     Structures begin differing at:
#          $got->{isbn_path}[0] = '979-10-90636-07-1'
#     $expected->{isbn_path}[0] = '979-1-09-063607-1'
# Looks like you failed 1 test of 7.
t/fix-isbn_versions.t .................. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/7 subtests 

Statistical analysis is not quite clear about the reasons; it could be caused by newer Catmandu or Business::ISBN, though I think that the latter is more likely:

****************************************************************
(3)
****************************************************************
Regression 'mod:Business::ISBN'
****************************************************************
Name                   Theta          StdErr     T-stat
[0='const']           1.0000          0.1182       8.46
[1='eq_3.002']        0.0000          0.1447       0.00
[2='eq_3.003']        0.0000          0.1671       0.00
[3='eq_3.004']       -0.0222          0.1195      -0.19
[4='eq_3.005']       -1.0000          0.1204      -8.30

R^2= 0.943, N= 75, K= 5
****************************************************************
(4)
****************************************************************
Regression 'mod:Catmandu'
****************************************************************
Name                   Theta          StdErr     T-stat
[0='const']           1.0000          0.1782       5.61
[1='eq_1.2002']      -0.1667          0.2057      -0.81
[2='eq_1.2003']      -0.5000          0.2520      -1.98
[3='eq_1.2004']      -0.4000          0.2108      -1.90
[4='eq_1.2006']      -0.2000          0.2108      -0.95
[5='eq_1.2007']      -0.1429          0.2020      -0.71
[6='eq_1.2008']       0.0000          0.1847       0.00
[7='eq_1.2009']      -1.0000          0.3086      -3.24
[8='eq_1.2010']      -1.0000          0.1869      -5.35

R^2= 0.757, N= 75, K= 9
****************************************************************
vpeil commented 4 years ago

Thanks for reporting. Version 0.14 is on its way to cpan.