search

LibreCat / Catmandu-MARC

Catmandu modules for working with MARC data
https://metacpan.org/release/Catmandu-MARC
Other
8 stars 10 forks source link

Integration of marc_spec #52

Closed cKlee closed 7 years ago

cKlee commented 7 years ago

To facilitate https://github.com/cKlee/Catmandu-Fix-marc_spec/issues/1 I think the best way is to integrate marc_spec into Catmandu::MARC like you did with marc_map. Do you have any concerns about this? @phochste @nichtich @jorol

phochste commented 7 years ago

Hi Carsten, I will work on this

Cheers

P@

On 18 Jan 2017, at 10:33, Carsten Klee notifications@github.com wrote:

To facilitate cKlee/Catmandu-Fix-marc_spec#1 I think the best way is to integrate marc_spec into Catmandu::MARC like you did with marc_map. Do you have any concerns about this? @phochste @nichtich @jorol

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

cKlee commented 7 years ago

Great! Let me know when I can help.

phochste commented 7 years ago

Can you give contributor rights or anything to overwrite Camandu-Fix-marc_spec on PAUSE. I don’y this I am allowed to upload a new version of Catmandu::MARC with Catmandu::Fix::marc_spec included

On 19 Jan 2017, at 08:04, Carsten Klee notifications@github.com wrote:

Great! Let me know when I can help.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

cKlee commented 7 years ago

PAUSE said: Added HOCHSTEN to co-maintainers of Catmandu::Fix::marc_spec

nichtich commented 7 years ago

For integration if marc_spec and marc_map as outlined at

I'd choose another (shorter) name for nested_arrays and optionally allow $ before subfield indicators. I'd also prefer _ instead of * as wildcard character.

cKlee commented 7 years ago

and optionally allow $ before subfield indicators. I'd also prefer _ instead of * as wildcard character.

Does this refer to MARCspec? The dollar sign in MARCspec is not optionally. It's necessary because MARCspec syntax can be very complex, Thus parsing subfield specs without the dollar could be very tricky and error prone. The underscore in MARCspec is used to indicate field indicators. MARCspec uses the dot as a wildcard. In my opinion this makes it more easy to match field tags.

phochste commented 7 years ago

I can also support the $ tag and _ wildcards. So if there is no big issues I would like to merge into dev next week.

cKlee commented 7 years ago

@phochste be aware of https://github.com/LibreCat/Catmandu-MARC/pull/55

phochste commented 7 years ago

Ok available in 1.08