search

LibreCat / Catmandu-SRU

Catmandu module for working with SRU data.
https://metacpan.org/release/Catmandu-SRU
5 stars 5 forks source link

add option total to sru_search() #39

Closed jorol closed 4 years ago

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.1%) to 89.175% when pulling 9bd6b68a47e27c550dc2bb6f96ac2775283e7732 on jorol:dev into 6a0cce1445de002e7c911cd46b54c31ee939673e on LibreCat:dev.

nics commented 5 years ago

why did you also remove limit, isn't it still useful to control how to records are fetched in the background?

jorol commented 5 years ago

I wanted total in the first place but mixed up with limit. My use case for this fix is to look up ids, names, places, etc. where I just get some records back in most cases. I‘m also a fan of leaving batch sizes to the SRU server. If you see a use for limit I can add it with another commit.

jorol commented 5 years ago

added option limit with another commit.

nics commented 4 years ago

Giving total a default value will constrain every request to 10 records, default should be to fetch all records, no?

jorol commented 4 years ago

Fixed with new commit.

nichtich commented 4 years ago

This has been implemented, so closing the pull request

jorol commented 4 years ago

Option totaland the change for the default of limit are not merged yet.

nics commented 4 years ago

@jorol released your changes as 0.429