search

LibreCat / Catmandu-SRU

Catmandu module for working with SRU data.
https://metacpan.org/release/Catmandu-SRU
5 stars 5 forks source link

Migrate to XML::Struct #4

Closed nichtich closed 10 years ago

nichtich commented 10 years ago

As discussed in https://github.com/LibreCat/Catmandu-SRU/issues/3 this does not force an array on record elements, so the change is not fully backwards compatible. One could provide other configuration values to xml, for instance to get raw DOM objects or XML strings.

phochste commented 10 years ago

Jacob, I saw it and I wonder about it for cases like DC. You never know if some DC records contain one identifier field or ten identifiers fields. Which makes DC->{identifier} sometimes a STRING and sometimes an ARRAY. Can XML::Struct solve this? I can pull it into the new parser code i've added to the master branch.

nichtich commented 10 years ago

We should better include test cases.

On 20. Februar 2014 15:07:42 MEZ, Patrick Hochstenbach notifications@github.com wrote:

Jacob, I saw it and I wonder about it for cases like DC. You never know if some DC records contain one identifier field or ten identifiers fields. Which makes DC->{identifier} sometimes a STRING and sometimes an ARRAY. Can XML::Struct solve this? I can pull it into the new parser code i've added to the master branch.

Reply to this email directly or view it on GitHub: https://github.com/LibreCat/Catmandu-SRU/pull/4#issuecomment-35624081

Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

phochste commented 10 years ago

Mja..I fear I have to make a bit more verbose to keep backwards compatibility