Additions to Catmandu::Store::MongoDB

[petrakohorst]

I added three methods to Catmandu::Store::MongoDB: getAll -> get all records in DB, getByFieldValue -> gets records with specified Value in specified Field, selectField -> returns all records but reduced to specified Field and _id

Please review.

[nics]

hi petra,

i see several probems with this:

• the main problem is that until now all stores have a common interface (Bag and maybe Searchable), these changes would break that. Not all stores can easily support getByFieldValue for example
• they are just shortcuts for bag->collection->...
• bag->getAll is the same as bag->to_array, which it inherits from Iterable (but your implementation is faster, so an overloaded to_array would be a good addition)
• all methods in Catmandu are under_score until now, not camelCase

that being said i want to add something like getByFieldValue (aka indexes)

now these methods are handy to have but it's probably better to make a subclass of Store::MongoDB or put them in a Moo::Role until then?

regards, nicolas

[petrakohorst]

Hi Nicolas,

thanks for the quick answer. I see what you mean about the common interface... I'll put those methods into a subclass of Store::MongoDB then (or find a way to work around them altogether), since I am not really familiar with Moo yet. Renaming the subs so they'll match the Catmandu naming convention should be no problem.

But, can the getAll method (renamed to to_array) stay in Store::MongoDB::Bag? Or should I put that into my new subclass as well?

Regards, Petra

[nics]

hi petra,

yes to_array can stay, i'll merge it in but it should return a reference to the array, that's what to_array usually returns:

sub to_array {                                                                                                            
    my ($self) = @_;                                                                                                      
    my @all = $self->collection->find->all;                                                                               
    \@all;                                                                                                                
}  

i'm working on prividing efficient versions of these Iterable methods in Store::Mongo:

pluck($key)->to_array can be used instead of selectField($key) in your case select($key => $val)->to_array can be used instead of getByFieldValue($key, $val)

these probably do what you need for Catmandu:Projects? ... then you won't need the subclass anymore and it''ll give you an idea on how to extend these methods to provide more efficient versions for a certain store

nicolas