LibreCat / Catmandu-Validator-JSONSchema

Catmandu Validator for JSON Schema
https://metacpan.org/pod/Catmandu::Validator::JSONSchema
Other
0 stars 0 forks source link

Use JSON::Validator to support JSON Schema v4 #2

Closed nichtich closed 8 years ago

nichtich commented 8 years ago

JSON::Validator looks good but it requires Mojolicious. JSV (see #1) looks less maintained, so use JSON::Validator instead?

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 91922b542d6ac0174a91ee937cb15b03e11b3b68 on json-validator into aa8ca8f8248999a350deb48efb4a5d52e8442d25 on master.

nicolasfranck commented 8 years ago

Sorry, didn't see the comment about the dependency Mojolicious. Seems a little bit heavy for a simple module. It uses Mojolicious for unknown reasons I think. Better first communicate with the creator of JSON::Validator to use other modules?

nichtich commented 8 years ago

I think they have their reasons and wont refactor just because third party use. As long as Catmandu-Validator-JSONSchema is optional to Catmandu, the heavy dependency is no urgent problem.

On 25. März 2016 08:57:28 MEZ, Nicolas Franck notifications@github.com wrote:

Sorry, didn't see the comment about the dependency Mojolicious. Seems a little bit heavy for a simple module. It uses Mojolicious for unknown reasons I think. Better first communicate with the creator of JSON::Validator to use other modules?


You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/LibreCat/Catmandu-Validator-JSONSchema/pull/2#issuecomment-201190490

Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

nicolasfranck commented 8 years ago

I spoke to the author of JSON::Validator, and indeed he won't refactor his code. Anyway, it's the only decent solution there is, so here we go