Adding support for handling of empty fields #19

LibreCat / Catmandu-XLS

an XLS exporter

https://metacpan.org/release/Catmandu-XLS

0 stars 2 forks source link

Adding support for handling of empty fields #19 #21

Closed phochste closed 3 years ago

phochste commented 3 years ago

Can you check this one. I don't know if the --empty option is the most elegant choice.

phochste commented 3 years ago

Maybe if --empty is used it should also has an explicit field to ignore empty values (and not only provide it as the default behavior):

default ( ignore ?)
string : treat empty as empty strings
nil : treat empty as null values
ignore : ignore empty fields

coveralls commented 3 years ago

Coverage remained the same at 88.889% when pulling 46cb658e2775586771739d04ce73da29e61b530a on pr/issue-19 into 4f74b22cf91f5c19b78eb4e5cbcbe75c5b714dea on master.

nics commented 3 years ago

I'll make 'string' the default to make it behave the same as the CSV package

nics commented 3 years ago

Added option value checking and simplified the code somewhat. Released as 0.10.