Trim Docker file to current Catmandu core

LibreCat / Catmandu

Catmandu - a data processing toolkit

https://librecat.org

175 stars 31 forks source link

Trim Docker file to current Catmandu core #345

Closed nichtich closed 6 years ago

nichtich commented 6 years ago

This modifies #344 to only build a minimal Docker image with Catmandu core. For properly tagged images, variable CATMANDU_VERSION in docker/Dockerfile must be updated before a new release so it will match the git tag! Unfortunately docker hub cannot access files below the docker directory and symlinks neither work, so dist.ini should be extended to automatically update the file such as Build.PL is updated. The docker image should also be documented in Pod to description ends up in README.md.

The default command in Dockerfile may also be replaced with ENTRYPOINT ["catmandu"] and CMD ["help"] instead of an interactive shell.

coveralls commented 6 years ago

Coverage remained the same at 93.584% when pulling 76292b4416c00db49fa0280c2e2a601205d8517a on docker into 956ae92b5f863e516c15ad2033b0a399befdaeed on dev.

coveralls commented 6 years ago

Coverage remained the same at 93.584% when pulling 76292b4416c00db49fa0280c2e2a601205d8517a on docker into 956ae92b5f863e516c15ad2033b0a399befdaeed on dev.

vpeil commented 6 years ago

@nichtich since we now have a a common understanding of building a minimal docker image for catmandu (which makes sense!), I have modified this case on the branch https://github.com/LibreCat/Catmandu/tree/docker2.

Features of the branch:

It builds catmandu from source (instead of using metacpan and a fixed version number)
it adds a user catmandu (because we can)
I moved Dockerfile back the the project root, which makes life a bit easier

If we'd go with that solution, I can configure docker hub to

have a build for the master branch (tagged latest)
have a build for the dev branch (tagged dev)
have a build for a specific tag (taggged {tag-name})

From that we can proceed an modify the https://github.com/LibreCat/docker-catmandu repository which was intended to provide a full demo version of catmandu with stores and sample data, etc.

nichtich commented 6 years ago

Thanks, this is better indeed! I added some minor comments to your changeset.

For https://github.com/LibreCat/docker-catmandu I'd rename or add catmandu-all with ''all'' available Catmandu modules (can be retrieved via Catmandu::Importer::Purr).

vpeil commented 6 years ago

PR #346 contains the requested changes.