search

LibreCodeCoop / whatsapp-client

WhatsApp web php client
GNU Affero General Public License v3.0
41 stars 12 forks source link

Implement PHPUnit #13

Closed maal26 closed 3 years ago

maal26 commented 3 years ago

closes #6

About item five (Implement Coveralls to view the% of coverage report in README.md), I followed the README instructions in the php-coveralls repository, so I don't know if it is correct because it's my first time doing this.

I generated the phpunit.xml config file using the command phpunit --generate-configuration and maybe have some "useless" rules. I added some more like: convert, stop and verbose rules.

vitormattos commented 3 years ago

closes #12 too, but have pending changes for TravisCI integration

maal26 commented 3 years ago

I pushed new commits with the necessary changes. Now I think everything is okay.

PS: I know that there is not the correct place to talk about this but in Hacktoberfest this repository has a legend of Ineligible Repository. Probably you need to add hacktoberfest topic to this repository or change the labels to "hacktoberfest-accepted".

vitormattos commented 3 years ago

I pushed new commits with the necessary changes. Now I think everything is okay.

PS: I know that there is not the correct place to talk about this but in Hacktoberfest this repository has a legend of Ineligible Repository. Probably you need to add hacktoberfest topic to this repository or change the labels to "hacktoberfest-accepted".

Solved