search

LibreDWG / libredwg

Official mirror of libredwg. With CI hooks and nightly releases. PR's ok
https://savannah.gnu.org/projects/libredwg/
GNU General Public License v3.0
931 stars 228 forks source link

Getting rid of "Recovery Mode" #996

Open timoria21 opened 1 month ago

timoria21 commented 1 month ago

With "Recovery Mode", I'm referring to an AutoCAD warning that appears when opening LibreDWG-generated DWG files.

Related to issue: https://github.com/LibreDWG/libredwg/issues/346

Material is broken, right? What about hardcoding a blob of data that belongs to the correct material so we can write all DWG file formats without "Recovery Mode"?

Or better, can you point me to the line of code that adds the material? Is it safe to remove it alone?

Thanks.

rurban commented 1 month ago

All material objects are already not written. I'm re-enabling it currently to see what's the real problem.

David J. Harris @.***> schrieb am Fr., 19. Juli 2024, 12:35:

Regarding the issue: #346 https://github.com/LibreDWG/libredwg/issues/346

Material is broken, right? What about hardcoding a blob of data that belongs to the correct material so we can write all DWG file formats without "Recovery Mode"?

Or better, can you point me to the line of code that adds the material? Is it safe to remove it alone?

Thanks.

— Reply to this email directly, view it on GitHub https://github.com/LibreDWG/libredwg/issues/996, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAKGUNEKQVLAJAPOCFQTZDZNDN7PAVCNFSM6AAAAABLEII4NKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYTQNJQGMZDIMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

timoria21 commented 1 month ago

Sorry, I'm not sure to understand.

Do you mean that the Material Objects writing was recently disabled?

I've tested write-dwg with version 0.13.3.7262-win64 and I believe that the issues causing recovery mode on files generated by AutoCAD versions later than 2000 were specifically related to materials. See this comment from the previous issue #346.

michal-josef-spacek commented 1 month ago

I need to retest with the actual version.

rurban commented 1 month ago

I need to retest with the actual version.

There's still the ACAD_MATERIALS dictionary to be fixed. And LAYER.plotstyle seems wrong

michal-josef-spacek commented 1 month ago

Actually blocked by https://github.com/LibreDWG/libredwg/issues/998