search

LibreHealthIO / lh-ehr-laravel

LibreHealth EHR laravel
27 stars 37 forks source link

Conflict between naming Facility and Facilities #14

Closed ayush0x00 closed 2 years ago

ayush0x00 commented 3 years ago

Describe the bug There are some scripts where folder name Facility is used and in code it is named app/Facilities which is causing error during migration of seed. To Reproduce Steps to reproduce the behavior: Just follow the installation process of current codebase.

Screenshot Screenshot from 2020-11-22 03-50-16

Expected behavior The codebase should have successfully migrated the seed.

Desktop (please complete the following information):

ayush0x00 commented 3 years ago

I would like to work on this issue.

muarachmann commented 3 years ago

I would like to work on this issue.

Nice catch go ahead!

ayush0x00 commented 3 years ago

Where is this error coming from? I have searched the whole project, app\Helper\ is nowhere to be found. I had to rename app\ to App\ to solve some path conflicts. And then i made sure to update the change to everywhere. Still, I am getting errors. @muarachmann could you please look in this.

Screenshot from 2020-11-22 19-55-32

muarachmann commented 3 years ago

I dont have this issue, the app/Helpers is correct, try to get the latest codes and let me know if this persist.

ayush0x00 commented 3 years ago

@muarachmann there is a lot of naming conflicts. Changing them, changes the whole codebase with quite a bunch of errors. I think we might have to revert back to a previous commit. How did the code get to run in the first place???. Sorry for late reply, my end term exams are going on.

muarachmann commented 3 years ago

No hurrying here, school first and best of lucks

muarachmann commented 2 years ago

Fixed