Calendar opens on medication outcome select (Resolved)

[muarachmann]

What issue is all about: The calender gets open when the medication field outcome - resolved is selected from the dropdown which is undesirable

Steps leading to issue: Select a patient > Go to medication > Add new > Click on the dropdown for outcome > select resolved

Screenshots

Errors from log files or console if any None

Would you like to solve this issue No, any first time contributor can be assigned to this

[muarachmann]

@aethelwulffe , @Trodrige can any of you add labels to this thanks. I would have but i aint got sufficient permissions for that

[aethelwulffe]

@muarachmann Gotcha.

[besong23]

Hello guys, I will like to work on this issue

[muarachmann]

@besong23 go ahead

[besong23]

Okay so after looking through the code the function outcomeClicked() turns to set the End Date value to current date so I have two ways of going about this, I can remove the function call as well as the function definition since it looks like the function is being called just ones OR I can remove just the function call and leave the function definition since I don't know if it might be needed later on. Which way should I go about this?

[muarachmann]

We dont want to define functions id they arent being use. There is no point to that. Do what you have to do to fix the issue and make a PR. From there we will review your code and tell you what you ought to do and not. As for finding a suitable method thats up to you 😃

[muarachmann]

Oh @aethelwulffe , @besong23 my bad. I didn't think this twice. When an issue is marked resolved, it should be ended and that is why it auto fills the form with the end date marking this stuff over. The issue to resolve here is preventing the opening of the calendar but that field (end date) should be filled with the current date of filling the issue. @besong23 hope you get it now. Let me give you a tip 😺 a focused field will draw attention to itself in all the form.

[besong23]

So that means it isn't at issue after all right?

[muarachmann]

You should learn to read @besong23 I said we want the field filled but the calendar is not to popup

[besong23]

Ah okay. Sorry about that :-)

[muarachmann]

And i gave you a tip. Its a one line issue stuff "a focused field will draw attention to itself in all the form."

[besong23]

@muarachmann I have opened a pull request for the issue

[aethelwulffe]

Referencing local PR #1252 Functional test needs to verify operation of all related forms. -Good job @besong23, and welcome to our team!

[aethelwulffe]

@muarachmann None of that "you should learn to read" stuff unless you want to hear "Mua, buddy, you should learn to write!" 😈 We have LOTS of non-native speakers, and not a lot of professional technical writers here! We will not tolerate intolerance 😜 Ndip is now your mentee @muarachmann for getting up to speed with the project. @besong23 ask any of us for help, but I think you should lean on Mua when you need something, because you two just did such a great job on this bug! 😃

[aethelwulffe]

[SERIOUS MODE ON] -I will get this test done this afternoon. Sorry for a delay.

[muarachmann]

You are right @aethelwulffe had a tough day but cool. roger that

[aethelwulffe]

@muarachmann Remember you can always download your troubles on us in the chat room! We will listen!