LibreHealthIO / lh-ehr

LibreHealth EHR - Free Open Source Electronic Health Records
Other
234 stars 258 forks source link

Changed Theme Color but now dropdown is same color. How to fix this? #1335

Open KoniKodes opened 5 years ago

KoniKodes commented 5 years ago

Previous: image

Current: image

tmccormi commented 5 years ago

Changing theme effects the colors, fonts of the drop downs, that's how it was done by that designer. It's not something that needs to be "fixed" per se.

I'm not saying it was a good idea, but it is what it is. We have never had anyone that is actually a true designer to give any of the themes much real thought.

KoniKodes commented 5 years ago

Thank you @tmccormi But it was so pretty the other way. Is there a way that I can help with this? I consider myself a front-end developer and designer: https://www.freecodecamp.org/certification/konikodes/legacy-front-end

tmccormi commented 5 years ago

The reason for posting here is to get volunteer devs. I know nothing about CSS, personally, however. IF you do you can make changes to the themes and submit them.

The CSS is "mostly" located in interface/themes/ directory. Here's a list.
style.css style_light.css style_prism.css style_purple.css style_tan.css style_tan_no_icons.css

@naveen17797 was working on a style color picker for end users... Not sure how far along that is.

KoniKodes commented 5 years ago

Thank you so much! I will look at these and see if I can be of any help.

KoniKodes commented 5 years ago

https://github.com/LibreHealthIO/lh-ehr/compare/master...KoniKodes:patch-1

I'm new to this and hope I did it properly...

muarachmann commented 5 years ago

@KoniKodes go ahead and create a Pull request

KoniKodes commented 5 years ago

@muarachmann I thought I did that with the link I provided. How can I do it correctly?

muarachmann commented 5 years ago

When you push your changes lets say to some branch online. Automatically git will detect a branch has been pushed. and will place a Pull request button you just need to click that and follow suite. Was this the case @KoniKodes . If not i will love to know how you pushed to github via git

KoniKodes commented 5 years ago

I think that's what I did. I clicked pull request for menu.css and it showed me with a new path.

muarachmann commented 5 years ago

Did you scroll down to finally click on create pull request. If so we should see your Pull request in the tab above num 49

muarachmann commented 5 years ago

Yes @KoniKodes thats it click on create PR

KoniKodes commented 5 years ago

Oh, I had to do it again. I think it worked...

KoniKodes commented 5 years ago

Update menu.css #1339

muarachmann commented 5 years ago

@KoniKodes i cant reproduce your screenshot are you having the latest version of the code?

KoniKodes commented 5 years ago

@muarachmann Which screen shot?

Our EHR Document site is at https://ehr.librehealth.io/interface/login/login.php?site=docs

KoniKodes commented 5 years ago

@muarachmann https://ehr.librehealth.io/interface/login/login.php?site=docs username: admin password: documentationisawesome

Takes you to https://ehr.librehealth.io/interface/main/tabs/main.php?url=TAB_ONE_DEFAULT

I am having the issues from this site...

aethelwulffe commented 5 years ago

Updates please?