search

LibreHealthIO / lh-ehr

LibreHealth EHR - Free Open Source Electronic Health Records
Other
238 stars 262 forks source link

Strange Filenames and extensions Showing alongside ID Card #1449

Open Ngai-E opened 5 years ago

Ngai-E commented 5 years ago

A) Outreachy Username: elizabeth

B) Issue Title: Patient ID Card displays file names and extension (.php and .jpg) to user.

C) Bug Report Date: March 15, 2019.

D) Site Affected: Documentation Site and NHANES

E) OS/ Browser Used: Chrome on Ubuntu 16.04

F) Which Workflow Module in LHEHR: Patient/Client => Finder.

G) Steps to Reproduce the Bug:

  1. Login to LibreHealth EHR.
  2. Select Finder drop down option from the Patient/Client menu item.
  3. Click on a patient name under Last Name from the entries shown, say, ‘Aaronson’ with Patient ID 83, for example.
  4. On the new module that appears, scroll down to where it says ID Card/Photos and click on expand if it is not already expanded.

H) At Point of the Bug, the Expected Behavior: User expects to have a clear view of Patient ID Card and photo if present.

I) Details of What Actually Happened: User finds Patient ID Card roughly displayed with strange files names and extensions not even useful in work flow. Using dev tool (inspector) on google chrome revealed that the filenames and extensions where actually outputted into a table row resulting to ‘Patient ID card <br>&nbsp;a9e07bb1010e26b4ed6ae414266d2195.jpg</td> and <td> <a href="/controller.php?document&amp;retrieve&amp;patient_id=83&amp;document_id=236" onclick="top.restoreSession()" class="css_button_small"><span>View</span></a> &nbsp;Patient Photograph - applicant.php </td> which in tend causes printing of the filenames and extensions.

J) Provide Relevant Screenshot and Explain the Screenshot: image Illustration 1: filenames and extensions alongside ID Card/Photos

K) Estimation of The Bug Severity: Module function continues with ongoing errors (Critical).

M) Suggested Solution: After inspecting the elements and their behavior with chrome dev tools, I discovered that this strange display was not caused by a static html content but was rather the return of a function call. Tracing this function to stop if from returning these filenames is how I suggest going about fix.

muarachmann commented 5 years ago

Okay you've got this

Ngai-E commented 5 years ago

ok

aethelwulffe commented 5 years ago

This is fixed, but the image has a download vs. display sort of thing going on if you click it. I think downloading should only be done from the patient documents tool, not from displaying the image.

muarachmann commented 5 years ago

Yeah If eliz could handle this it would be great :)

On Thu, May 9, 2019 at 5:00 PM Art Eaton notifications@github.com wrote:

This is fixed, but the image has a download vs. display sort of thing going on if you click it. I think downloading should only be done from the patient documents tool, not from displaying the image.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/lh-ehr/issues/1449#issuecomment-490964250, or mute the thread https://github.com/notifications/unsubscribe-auth/AD4X4XXUL7G2PNBEMHOEYYTPURDAXANCNFSM4G7PDYUQ .

aethelwulffe commented 5 years ago

Yeah, eLiz is on this...and we should stick her with the responsibility!  :)

On 2019-05-09 12:02, muarachmann wrote:

Yeah If eliz could handle this it would be great :)

On Thu, May 9, 2019 at 5:00 PM Art Eaton notifications@github.com wrote:

This is fixed, but the image has a download vs. display sort of thing going on if you click it. I think downloading should only be done from the patient documents tool, not from displaying the image.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub

https://github.com/LibreHealthIO/lh-ehr/issues/1449#issuecomment-490964250, or mute the thread

https://github.com/notifications/unsubscribe-auth/AD4X4XXUL7G2PNBEMHOEYYTPURDAXANCNFSM4G7PDYUQ .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/lh-ehr/issues/1449#issuecomment-490965146, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEHGF462ZB3LQIC6BYH7OTPURDKDANCNFSM4G7PDYUQ.

Ngai-E commented 5 years ago

Ok. Thought of fixing it, but I did not know if it was the expected behavior I will surely look into it now thanks.

aethelwulffe commented 5 years ago

No, while being able to download some things like that directly is good, the default should be display in browser.  This is either a legacy thing or lazy developer thing.

Puhleezz fix it.

On 2019-05-09 12:38, Ngai Elizabeth wrote:

Ok. Thought of fixing it, but I did not know if it was the expected behavior I will surely look into it now thanks.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/lh-ehr/issues/1449#issuecomment-490977869, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEHGF2R22C6MS7RYGIZV4LPURHSBANCNFSM4G7PDYUQ.

Ngai-E commented 5 years ago

No, while being able to download some things like that directly is good, the default should be display in browser.  This is either a legacy thing or lazy developer thing. Puhleezz fix it. … On 2019-05-09 12:38, Ngai Elizabeth wrote: Ok. Thought of fixing it, but I did not know if it was the expected behavior I will surely look into it now thanks. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1449 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEHGF2R22C6MS7RYGIZV4LPURHSBANCNFSM4G7PDYUQ.

I tried fixing this but I realized that the download stuff happens for files that can not be viewed. How do I go about fixing this since i can not display it either when the user clicks on view.

image

What should I put as default behaviour for a non viewable type of image.

muarachmann commented 5 years ago

The download can be ok here for the non viewable stuff. btw how will an image not be viewable?

On Thu, May 16, 2019 at 9:56 AM Ngai Elizabeth notifications@github.com wrote:

No, while being able to download some things like that directly is good, the default should be display in browser. This is either a legacy thing or lazy developer thing. Puhleezz fix it. … <#m-2268844759158720982> On 2019-05-09 12:38, Ngai Elizabeth wrote: Ok. Thought of fixing it, but I did not know if it was the expected behavior I will surely look into it now thanks. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1449 (comment) https://github.com/LibreHealthIO/lh-ehr/issues/1449#issuecomment-490977869>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEHGF2R22C6MS7RYGIZV4LPURHSBANCNFSM4G7PDYUQ .

I tried fixing this but I realized that the download stuff happens for files that can not be viewed. How do I go about fixing this since i can not display it either when the user clicks on view.

[image: image] https://user-images.githubusercontent.com/22508583/57840525-b411c380-77c0-11e9-95f3-0b75e64171da.png

What should I put as default behaviour for a non viewable type of image.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/lh-ehr/issues/1449?email_source=notifications&email_token=AD4X4XRMM5BGQBY5L52THODPVUOVVA5CNFSM4G7PDYU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVREV5Q#issuecomment-492980982, or mute the thread https://github.com/notifications/unsubscribe-auth/AD4X4XT2ZV3MCWUMT4JNB6DPVUOVVANCNFSM4G7PDYUQ .

muarachmann commented 5 years ago

I think the type is restricted in the uploads to accept only those extensions right?

On Thu, May 16, 2019 at 11:58 AM Mua Rachmann muarachmann@gmail.com wrote:

The download can be ok here for the non viewable stuff. btw how will an image not be viewable?

On Thu, May 16, 2019 at 9:56 AM Ngai Elizabeth notifications@github.com wrote:

No, while being able to download some things like that directly is good, the default should be display in browser. This is either a legacy thing or lazy developer thing. Puhleezz fix it. … <#m-2268844759158720982> On 2019-05-09 12:38, Ngai Elizabeth wrote: Ok. Thought of fixing it, but I did not know if it was the expected behavior I will surely look into it now thanks. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1449 (comment) https://github.com/LibreHealthIO/lh-ehr/issues/1449#issuecomment-490977869>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEHGF2R22C6MS7RYGIZV4LPURHSBANCNFSM4G7PDYUQ .

I tried fixing this but I realized that the download stuff happens for files that can not be viewed. How do I go about fixing this since i can not display it either when the user clicks on view.

[image: image] https://user-images.githubusercontent.com/22508583/57840525-b411c380-77c0-11e9-95f3-0b75e64171da.png

What should I put as default behaviour for a non viewable type of image.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/lh-ehr/issues/1449?email_source=notifications&email_token=AD4X4XRMM5BGQBY5L52THODPVUOVVA5CNFSM4G7PDYU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVREV5Q#issuecomment-492980982, or mute the thread https://github.com/notifications/unsubscribe-auth/AD4X4XT2ZV3MCWUMT4JNB6DPVUOVVANCNFSM4G7PDYUQ .

Ngai-E commented 5 years ago

I think the type is restricted in the uploads to accept only those extensions right? … On Thu, May 16, 2019 at 11:58 AM Mua Rachmann @.> wrote: The download can be ok here for the non viewable stuff. btw how will an image not be viewable? On Thu, May 16, 2019 at 9:56 AM Ngai Elizabeth @.> wrote: > No, while being able to download some things like that directly is good, > the default should be display in browser. This is either a legacy thing or > lazy developer thing. Puhleezz fix it. > … <#m-2268844759158720982> > On 2019-05-09 12:38, Ngai Elizabeth wrote: Ok. Thought of fixing it, but > I did not know if it was the expected behavior I will surely look into it > now thanks. — You are receiving this because you commented. Reply to this > email directly, view it on GitHub <#1449 (comment) > <#1449 (comment)>>, > or mute the thread > https://github.com/notifications/unsubscribe-auth/AAEHGF2R22C6MS7RYGIZV4LPURHSBANCNFSM4G7PDYUQ > . > > I tried fixing this but I realized that the download stuff happens for > files that can not be viewed. How do I go about fixing this since i can not > display it either when the user clicks on view. > > [image: image] > https://user-images.githubusercontent.com/22508583/57840525-b411c380-77c0-11e9-95f3-0b75e64171da.png > > What should I put as default behaviour for a non viewable type of image. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#1449?email_source=notifications&email_token=AD4X4XRMM5BGQBY5L52THODPVUOVVA5CNFSM4G7PDYU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVREV5Q#issuecomment-492980982>, > or mute the thread > https://github.com/notifications/unsubscribe-auth/AD4X4XT2ZV3MCWUMT4JNB6DPVUOVVANCNFSM4G7PDYUQ > . >

No. That is the problem. It is possible to upload a .pdf file and if this is done you only get the download prompt when you click on 'View' since it is not viewable

Ngai-E commented 5 years ago

I think we can start fixing it by restricting the upload to only viewable image files like .png, jpeg, jpg etc. I wanted to do this but thought i should ask first.

muarachmann commented 5 years ago

Patient ID card /Patient photograph thats what i see in the docs. Why should this be uploaded as PDF. I would say rather check the extensions during upload in these areas and restrict it to the viewables. IMO

On Thu, May 16, 2019 at 12:10 PM Ngai Elizabeth notifications@github.com wrote:

I think we can start fixing it by restricting the upload to only viewable image files like .png, jpeg, jpg etc. I wanted to do this but thought i should ask first.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/lh-ehr/issues/1449?email_source=notifications&email_token=AD4X4XTKB7CU525AK6QZD5DPVU6MBA5CNFSM4G7PDYU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVRPIYY#issuecomment-493024355, or mute the thread https://github.com/notifications/unsubscribe-auth/AD4X4XSCBATFJCEA3WKX7UDPVU6MBANCNFSM4G7PDYUQ .

Ngai-E commented 5 years ago

Patient ID card /Patient photograph thats what i see in the docs. Why should this be uploaded as PDF. I would say rather check the extensions during upload in these areas and restrict it to the viewables. IMO … On Thu, May 16, 2019 at 12:10 PM Ngai Elizabeth @.***> wrote: I think we can start fixing it by restricting the upload to only viewable image files like .png, jpeg, jpg etc. I wanted to do this but thought i should ask first. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1449?email_source=notifications&email_token=AD4X4XTKB7CU525AK6QZD5DPVU6MBA5CNFSM4G7PDYU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVRPIYY#issuecomment-493024355>, or mute the thread https://github.com/notifications/unsubscribe-auth/AD4X4XSCBATFJCEA3WKX7UDPVU6MBANCNFSM4G7PDYUQ .

ok

aethelwulffe commented 5 years ago

NOOOOOOOOOO! The docs are for tons of other stuff. You can have DICOM format image and video files, a variety of formats of various word processor files, pdf's, SAS files...you name it. The restrictions should be configurable, and only rule out things like are typically blocked on an email server, like .exe, .scr, .bat etc... You can have .zip/rar, but ruling out .cab is reasonable. Still, this is really the in-house clinic FTP for patient stuff, and can't be treated with the same level of restrictions you would place on a fan-forum uploader.

aethelwulffe commented 5 years ago

It should download. Otherwise, your browser has to be set to perform a certain action for a certain type of file. That is the user's sysadmin issue. It should function as per the browser's default. Displaying in place should be for image files, otherwise, leave it up to the browser, or as a download link.

When a file is viewable, there could be a [view] button beside it as well as a [download] button. This could be nice, as could a "help" button with some text describing how to alter browser behavior.

aethelwulffe commented 5 years ago

ID card and license image files of restricted size (and number) should be the only things POSSIBLE to upload to a (virtual) directory linked to the photo display in dems. If you go to demographics and pick "Documents", you can upload anything you like there, which could make things goofy. This is not a directory restriction, it is a setting for items linked to that "directory" row in categories_to_documents. As you see in sites/[sitename]/documents, you have directories named after the patient PID, then everything gets dumped there. No subdir involved. the documents table handles the organization, as per indexes in categories_to_documents. -You guys probably already realize much of this. Don't ask me what all documentslegal stuff does. We need to review that stuff. There is also a separate system for the patient portal, and onandon.